Skip to content

Fixed temp dir owner actor id serialization #20683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed temp dir owner actor id serialization #20683

wants to merge 3 commits into from

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Jul 6, 2025 •
edited
Loading

Changelog entry

Fixed temp dir owner actor id serialization

Changelog category

  • Bugfix

Description for reviewers

When restarting the SS tablet, the TempDirOwnerActorId pool id is lost and the temporary tables are dropped because it is not possible to send an Ack to the actor. Fixed serialization for TempDirOwnerActorId, pool id is now saved.

@GrigoriyPA GrigoriyPA requested review from ijon and nikvas0 July 6, 2025 19:10
@GrigoriyPA GrigoriyPA requested review from a team as code owners July 6, 2025 19:10
@github-actions github-actions bot added the bugfix label Jul 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2025 •
edited
Loading

🔴 2025-07-07 08:19:32 UTC The validation of the Pull Request description has failed. Please update the description.

Bugfix requires a linked issue in the changelog entry

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2025 •
edited
Loading

⚪ 2025-07-06 19:14:11 UTC Pre-commit check linux-x86_64-release-asan for 9341c2c has started.
⚪ 2025-07-06 19:14:21 UTC Artifacts will be uploaded here
⚪ 2025-07-06 19:17:37 UTC ya make is running...
🟡 2025-07-06 21:01:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14327 13986 0 105 201 35

🟢 2025-07-06 21:02:42 UTC Build successful.
🟢 2025-07-06 21:03:09 UTC ydbd size 3.9 GiB changed* by +36.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 9341c2c diff diff %
ydbd size 4 200 002 176 Bytes 4 200 039 416 Bytes +36.4 KiB +0.001%
ydbd stripped size 1 455 233 272 Bytes 1 455 240 920 Bytes +7.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2025 •
edited
Loading

⚪ 2025-07-06 19:14:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9341c2c has started.
⚪ 2025-07-06 19:14:24 UTC Artifacts will be uploaded here
⚪ 2025-07-06 19:17:42 UTC ya make is running...
🟡 2025-07-06 20:22:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29714 28306 0 3 1360 45

⚪ 2025-07-06 20:24:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-06 20:35:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
253 (only retried tests) 211 0 1 2 39

⚪ 2025-07-06 20:36:09 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-06 20:46:58 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
239 (only retried tests) 197 0 1 2 39

🟢 2025-07-06 20:47:05 UTC Build successful.
🟢 2025-07-06 20:47:24 UTC ydbd size 2.2 GiB changed* by +29.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: 9341c2c diff diff %
ydbd size 2 387 865 384 Bytes 2 387 895 800 Bytes +29.7 KiB +0.001%
ydbd stripped size 499 603 048 Bytes 499 610 600 Bytes +7.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

⚪ 2025-07-07 04:41:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for df6b3bb has started.
⚪ 2025-07-07 04:41:57 UTC Artifacts will be uploaded here
⚪ 2025-07-07 04:45:08 UTC ya make is running...
🟡 2025-07-07 05:43:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29714 28303 0 1 1361 49

⚪ 2025-07-07 05:46:18 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 05:53:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
397 (only retried tests) 355 0 0 2 40

🟢 2025-07-07 06:22:30 UTC Build successful.
🟢 2025-07-07 06:22:57 UTC ydbd size 2.2 GiB changed* by +29.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: df6b3bb diff diff %
ydbd size 2 387 865 384 Bytes 2 387 895 800 Bytes +29.7 KiB +0.001%
ydbd stripped size 499 603 048 Bytes 499 610 600 Bytes +7.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

⚪ 2025-07-07 04:41:55 UTC Pre-commit check linux-x86_64-release-asan for df6b3bb has started.
⚪ 2025-07-07 04:42:07 UTC Artifacts will be uploaded here
⚪ 2025-07-07 04:45:27 UTC ya make is running...
🟡 2025-07-07 06:25:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14327 13889 0 213 196 29

🟢 2025-07-07 06:26:53 UTC Build successful.
🟢 2025-07-07 06:27:19 UTC ydbd size 3.9 GiB changed* by +36.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c59858d merge: df6b3bb diff diff %
ydbd size 4 200 002 176 Bytes 4 200 039 416 Bytes +36.4 KiB +0.001%
ydbd stripped size 1 455 233 272 Bytes 1 455 240 920 Bytes +7.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA added the rebase-and-check Rebase PR with the current base branch and check label Jul 7, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

⚪ 2025-07-07 07:07:02 UTC Pre-commit check linux-x86_64-release-asan for 1061d35 has started.
⚪ 2025-07-07 07:07:13 UTC Artifacts will be uploaded here
⚪ 2025-07-07 07:10:33 UTC ya make is running...
🟡 2025-07-07 08:53:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14327 13944 0 148 202 33

🟢 2025-07-07 08:54:47 UTC Build successful.
🟢 2025-07-07 08:55:13 UTC ydbd size 3.9 GiB changed* by +36.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0297d5d merge: 1061d35 diff diff %
ydbd size 4 200 005 664 Bytes 4 200 043 016 Bytes +36.5 KiB +0.001%
ydbd stripped size 1 455 234 488 Bytes 1 455 242 136 Bytes +7.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

⚪ 2025-07-07 07:08:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1061d35 has started.
⚪ 2025-07-07 07:08:56 UTC Artifacts will be uploaded here
⚪ 2025-07-07 07:12:18 UTC ya make is running...
🟡 2025-07-07 08:16:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29714 28302 0 3 1360 49

⚪ 2025-07-07 08:19:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 08:31:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
299 (only retried tests) 257 0 0 2 40

🟢 2025-07-07 08:31:20 UTC Build successful.
🟢 2025-07-07 08:31:41 UTC ydbd size 2.2 GiB changed* by +29.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0297d5d merge: 1061d35 diff diff %
ydbd size 2 387 867 992 Bytes 2 387 898 520 Bytes +29.8 KiB +0.001%
ydbd stripped size 499 603 752 Bytes 499 611 368 Bytes +7.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikvas0 nikvas0 nikvas0 approved these changes

@ijon ijon Awaiting requested review from ijon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoriyPA @nikvas0